From 030c220d7e2a192a5709c953b46f0f287aed4b9b Mon Sep 17 00:00:00 2001 From: kramo <93832451+kra-mo@users.noreply.github.com> Date: Sat, 25 Mar 2023 00:50:17 +0100 Subject: [PATCH] Cleanups --- src/game.py | 4 +--- src/utils/create_details_window.py | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/game.py b/src/game.py index b767f78..abf9bd2 100644 --- a/src/game.py +++ b/src/game.py @@ -80,9 +80,7 @@ class game(Gtk.Box): # pylint: disable=invalid-name subprocess.Popen( ["flatpak-spawn", "--host", *self.executable] # Flatpak if os.getenv("FLATPAK_ID") == "hu.kramo.Cartridges" - else self.executable # Windows - if os.name == "nt" - else self.executable, # Linux/Others + else self.executable, # Others start_new_session=True, creationflags=subprocess.CREATE_NEW_PROCESS_GROUP if os.name == "nt" else 0, ) diff --git a/src/utils/create_details_window.py b/src/utils/create_details_window.py index 7ac44fd..644a5e6 100644 --- a/src/utils/create_details_window.py +++ b/src/utils/create_details_window.py @@ -206,13 +206,13 @@ def create_details_window(parent_widget, game_id=None): final_executable_split = shlex.split( final_executable, comments=False, posix=True ) - except Exception as e: + except ValueError as exception: create_dialog( window, _("Couldn't Add Game") if game_id is None else _("Couldn't Apply Preferences"), - f'{_("Executable")}: {e}.', # e = Shell parsing error message. Not translatable. + f'{_("Executable")}: {exception}.', ) return