skullbite/cartridges
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

More sensible approach to screen reader in popups

Browse Source
This commit is contained in:
kramo
2023-08-16 17:22:12 +02:00
parent 8dc96b53b2
commit 0e2918cfe8
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
data/gtk/details-window.blp
View File

@@ -127,7 +127,6 @@ template $DetailsWindow : Adw.Window {
margin-bottom: 6; margin-bottom: 6;
margin-start: 6; margin-start: 6;
margin-end: 6; margin-end: 6;
selectable: true;
} }
}; };

15
src/details_window.py
View File

@@ -48,6 +48,7 @@ class DetailsWindow(Adw.Window):
developer = Gtk.Template.Child() developer = Gtk.Template.Child()
executable = Gtk.Template.Child() executable = Gtk.Template.Child()
exec_info_button = Gtk.Template.Child()
exec_info_label = Gtk.Template.Child() exec_info_label = Gtk.Template.Child()
exec_info_popover = Gtk.Template.Child() exec_info_popover = Gtk.Template.Child()
@@ -114,10 +115,18 @@ class DetailsWindow(Adw.Window):
self.exec_info_label.set_label(exec_info_text) self.exec_info_label.set_label(exec_info_text)
def clear_info_selection(*_args: Any) -> None: self.exec_info_popover.set_focusable(True)
self.exec_info_label.select_region(-1, -1) self.exec_info_popover.update_property(
(Gtk.AccessibleProperty.LABEL,),
(
exec_info_text.replace("<tt>", "").replace("</tt>", ""),
), # Remove formatting, else the screen reader reads it
)
self.exec_info_popover.connect("show", clear_info_selection) def set_exec_info_a11y_label(*_args: Any) -> None:
self.set_focus(self.exec_info_popover)
self.exec_info_popover.connect("show", set_exec_info_a11y_label)
self.cover_button_delete.connect("clicked", self.delete_pixbuf) self.cover_button_delete.connect("clicked", self.delete_pixbuf)
self.cover_button_edit.connect("clicked", self.choose_cover) self.cover_button_edit.connect("clicked", self.choose_cover)