skullbite/cartridges
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Auto-import only if changes would have effect

Browse Source
This commit is contained in:
kramo
2023-05-15 16:20:05 +02:00
parent 53f273d434
commit 6db43213f0
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/preferences.py
View File

@@ -219,20 +219,21 @@ class PreferencesWindow(Adw.PreferencesWindow):
# Cartridges should automatically import upon closing the preferences window # Cartridges should automatically import upon closing the preferences window
self.connect("close-request", self.check_import) self.connect("close-request", self.check_import)
def get_switch(self, setting):
return getattr(self, f'{setting.replace("-", "_")}_switch')
def bind_switches(self, settings): def bind_switches(self, settings):
for setting in settings: for setting in settings:
self.schema.bind( self.schema.bind(
setting, setting,
getattr(self, f'{setting.replace("-", "_")}_switch'), self.get_switch(setting),
"active", "active",
Gio.SettingsBindFlags.DEFAULT, Gio.SettingsBindFlags.DEFAULT,
) )
def connect_import_switches(self, settings): def connect_import_switches(self, settings):
for setting in settings: for setting in settings:
getattr(self, f'{setting.replace("-", "_")}_switch').connect( self.get_switch(setting).connect("notify::active", self.set_import_changed)
"notify::active", self.set_import_changed, True
)
def choose_folder(self, _widget, function): def choose_folder(self, _widget, function):
self.file_chooser.select_folder(self.win, None, function, None) self.file_chooser.select_folder(self.win, None, function, None)
@@ -295,11 +296,12 @@ class PreferencesWindow(Adw.PreferencesWindow):
) )
getattr(win, f"{source_id}_expander_row").connect( getattr(win, f"{source_id}_expander_row").connect(
"notify::enable-expansion", self.set_import_changed, True "notify::enable-expansion", self.set_import_changed
) )
def set_import_changed(self, _widget, _param, value): def set_import_changed(self, widget, param):
self.import_changed = value if widget.get_property(param.name):
self.import_changed = True
def check_import(self, *_args): def check_import(self, *_args):
if self.import_changed: if self.import_changed: