A few minor code cleanups and fixes (#47)

* Avoid exception if trying to delete missing "removed" key

`.pop(key)` throws an exception if that `key` is missing. Using a default value (in this case None) means we don't throw any errors when deleting a missing key. Which is what we want here, for safety. We just want to delete the key. We don't care if it's existing or not.

There are other places in the codebase that also use `.pop(key)`, but all of those first check the validity of the key before popping, so this was the only one that needed fixing.

* Improve performance by removing keys() calls

Every `.keys()` call create a new `[list...]` of all keys from the given dictionary. It's a total waste of performance, since we can already check if a key exists in a dictionary by just using `if "key" in the_dict`.

* Use more pythonic "not in" syntax

The syntax is supposed to be `if "thing" not in other_thing`. We already use this proper `not in` syntax everywhere else in the codebase. Just fixing this location.
This commit is contained in:
Bananaman
2023-03-31 15:24:02 +02:00
committed by GitHub
parent 780fd0a09f
commit 77b083e219
4 changed files with 9 additions and 9 deletions

View File

@@ -57,7 +57,7 @@ class Importer:
self.games_no += 1
save_game(values)
self.parent_widget.update_games([values["game_id"]])
if "blacklisted" in values.keys():
if "blacklisted" in values:
self.games_no -= 1
self.queue -= 1