From 9f582dfa3e43b9577e851d002811bc7100ead560 Mon Sep 17 00:00:00 2001
From: kramo <93832451+kra-mo@users.noreply.github.com>
Date: Mon, 19 Jun 2023 19:31:27 +0200
Subject: [PATCH] Improve a11y and consistency for info popover

---
 data/gtk/details_window.blp | 10 ++++++----
 src/details_window.py       |  6 ++++++
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/data/gtk/details_window.blp b/data/gtk/details_window.blp
index 8ca1cab..ecddb13 100644
--- a/data/gtk/details_window.blp
+++ b/data/gtk/details_window.blp
@@ -129,17 +129,19 @@ template $DetailsWindow : Adw.Window {
                     icon-name: "help-about-symbolic";
                     tooltip-text: _("More Info");
 
-                    popover: Popover {
-                        visible: bind-property exec_info_button.active bidirectional;
+                    popover: Popover exec_info_popover {
 
                         Label exec_info_label {
                             use-markup: true;
                             wrap: true;
-                            max-width-chars: 30;
+                            max-width-chars: 50;
+                            halign: center;
+                            valign: center;
                             margin-top: 6;
-                            margin-bottom: 12;
+                            margin-bottom: 6;
                             margin-start: 6;
                             margin-end: 6;
+                            selectable: true;
                         }
                     };
 
diff --git a/src/details_window.py b/src/details_window.py
index b91534a..c226a3b 100644
--- a/src/details_window.py
+++ b/src/details_window.py
@@ -48,6 +48,7 @@ class DetailsWindow(Adw.Window):
     executable = Gtk.Template.Child()
 
     exec_info_label = Gtk.Template.Child()
+    exec_info_popover = Gtk.Template.Child()
 
     apply_button = Gtk.Template.Child()
 
@@ -112,6 +113,11 @@ class DetailsWindow(Adw.Window):
 
         self.exec_info_label.set_label(exec_info_text)
 
+        def clear_info_selection(*_args):
+            self.exec_info_label.select_region(0, 0)
+
+        self.exec_info_popover.connect("show", clear_info_selection)
+
         self.cover_button_delete.connect("clicked", self.delete_pixbuf)
         self.cover_button_edit.connect("clicked", self.choose_cover)
         self.apply_button.connect("clicked", self.apply_preferences)