skullbite/cartridges
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🎨 Better error handling in managers

Browse Source
This commit is contained in:
GeoffreyCoulaud
2023-05-31 17:21:01 +02:00
parent d204737339
commit ef63210a8f
4 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/store/managers/manager.py
View File

@@ -56,22 +56,24 @@ class Manager:
self.manager_logic(game)
except Exception as error:
# Handle unretryable errors
log_args = (type(error).__name__, self.name, game.game_id)
if type(error) in self.retryable_on:
logging.error("Unretryable %s in %s for %s", *log_args)
log_args = (type(error).__name__, self.name, game.name, game.game_id)
if type(error) not in self.retryable_on:
logging.error("Unretryable %s in %s for %s (%s)", *log_args)
self.report_error(error)
break
# Handle being out of retries
elif remaining_tries == 0:
logging.error("Too many retries due to %s in %s for %s", *log_args)
logging.error(
"Too many retries due to %s in %s for %s (%s)", *log_args
)
self.report_error(error)
break
# Retry
else:
logging.debug("Retry caused by %s in %s for %s", *log_args)
logging.debug("Retry caused by %s in %s for %s (%s)", *log_args)
continue
def process_game(self, game: Game, callback: Callable[["Manager"], Any]) -> None:
"""Pass the game through the manager"""
self.execute_resilient_manager_logic(game, tries=0)
self.execute_resilient_manager_logic(game)
callback(self)

4
src/store/managers/sgdb_manager.py
View File

@@ -1,9 +1,7 @@
from requests import HTTPError
from src.game import Game
from src.store.managers.async_manager import AsyncManager
from src.store.managers.steam_api_manager import SteamAPIManager
from src.utils.steamgriddb import HTTPError, SGDBAuthError, SGDBError, SGDBHelper
from src.utils.steamgriddb import HTTPError, SGDBAuthError, SGDBHelper
class SGDBManager(AsyncManager):