Commit Graph

35 Commits

Author SHA1 Message Date
Bananaman
77b083e219 A few minor code cleanups and fixes (#47)
* Avoid exception if trying to delete missing "removed" key

`.pop(key)` throws an exception if that `key` is missing. Using a default value (in this case None) means we don't throw any errors when deleting a missing key. Which is what we want here, for safety. We just want to delete the key. We don't care if it's existing or not.

There are other places in the codebase that also use `.pop(key)`, but all of those first check the validity of the key before popping, so this was the only one that needed fixing.

* Improve performance by removing keys() calls

Every `.keys()` call create a new `[list...]` of all keys from the given dictionary. It's a total waste of performance, since we can already check if a key exists in a dictionary by just using `if "key" in the_dict`.

* Use more pythonic "not in" syntax

The syntax is supposed to be `if "thing" not in other_thing`. We already use this proper `not in` syntax everywhere else in the codebase. Just fixing this location.
2023-03-31 15:24:02 +02:00
kramo
dad4905753 Cleanups 2023-03-29 23:02:10 +02:00
kramo
643ca368a6 Unify games import 2023-03-29 00:23:23 +02:00
kramo
228db1b2f0 Add option to launch games by clicking cover 2023-03-26 11:04:40 +02:00
kramo
65357bdc41 UX improvements 2023-03-25 08:36:13 +01:00
kramo
41c97e1af7 Move menu models to the game class 2023-03-25 00:14:37 +01:00
kramo
6b103c996b Remove redundant get_cover function 2023-03-24 23:09:56 +01:00
Domenico
053d5791a4 Refactory of the code (#19)
* Refactory of the code

* Autoformatting with black

---------

Co-authored-by: Domefemia <domefemia@hotmail.com>
2023-03-24 20:26:55 +01:00
kramo
b281a4bd0d Cleanups 2023-03-22 08:36:37 +01:00
kramo
57be95137c Update translations 2023-03-19 13:12:35 +01:00
kramo
a4cc224aa5 Update translations 2023-03-19 12:56:00 +01:00
kramo
ba944fdaab Revert to resolve Weblate conflict 2023-03-19 12:53:49 +01:00
kramo
cad5c3fd36 Update translations 2023-03-19 12:42:00 +01:00
kramo
516c020cbc Allow building as a non-flatpak app 2023-03-16 17:24:03 +01:00
kramo
eb3f9a8b8e Use blacklist for non-game items 2023-03-15 23:46:34 +01:00
kramo
e2a2ea6da2 Add developer property 2023-03-15 13:12:48 +01:00
kramo
8a2ff2561b Cleanups 2023-03-15 02:22:11 +01:00
kramo
bd0cf7402a Code style 2023-03-15 01:57:43 +01:00
kramo
f416155c2d Update code style 2023-03-14 23:05:47 +01:00
kramo
32d9f9a880 Cleanups 2023-03-14 21:20:59 +01:00
kramo
41762648b2 Update potfile 2023-03-14 18:52:06 +01:00
kramo
24eac24c33 Better image handling 2023-03-14 18:42:05 +01:00
kramo
094bfad10d Cleanups 2023-03-14 17:21:16 +01:00
kramo
a4b1b8efd9 Refactor 2023-03-14 16:48:00 +01:00
kramo
35185205e3 Async image saving 2023-03-13 23:09:51 +01:00
kramo
4e081bd7ee Fix library focus issue 2023-03-11 23:52:38 +01:00
kramo
aa77fc8bf3 Show play button on hover - closes #4 2023-03-11 22:07:56 +01:00
kramo
a0a67fd2ca Update project structure 2023-02-19 20:06:45 +01:00
kramo
e87e96f3c6 Add keyboard shortcuts 2023-02-19 19:30:07 +01:00
kramo
8718a6a170 Save window geometry 2023-02-18 21:16:57 +01:00
kramo
325820758e Add mouse navigation 2023-02-02 15:21:58 +01:00
kramo
5e373bd63d Cleanups 2023-02-01 17:26:55 +01:00
kramo
a9a5a1d3c2 Rename to Cartridges 2023-02-01 16:34:26 +01:00
kra-mo
731ed439d5 Update GTK code style 2023-01-14 23:47:27 +01:00
kra-mo
f5c1012628 Add project files 2022-12-26 14:38:37 +01:00