skullbite/cartridges
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,363 Commits 20 Branches 64 Tags
14522bdcb06ab6737ce2cb44e4a93df6703cd4fa
Commit Graph

1363 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
kramo
501ca75a02 Merge pull request #22 from Bananaman/windows_launching 
Refactor game launching, and fix Windows support
 2023-03-25 14:56:29 +01:00
Bananaman
732bb77192 Refactor game launching, and fix Windows support 
The function was getting a bit convoluted to follow, and there was a maintenance burden of having to remember that "shell=True" should only be true if the argument is a single string to be passed exactly as-is to the shell. If it's a list, only the first value in the list would be ran as the shell command and the rest would be given as arguments to the shell itself.

Therefore, it's been refactored to automatically determine shell-mode based on whether "args" is a list or a string.

On Windows, we now generate a correctly escaped shell-string via "shlex". This ensures that we properly support spaces inside quoted launch arguments, by auto-escaping them on a per-argument basis.

The extra pylint hint is needed because the import is detected as unused on non-Windows machines.
 2023-03-25 14:29:28 +01:00
Hosted Weblate
f1b9a59c54 Update translation files 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/
Translation: Cartridges/Cartridges
 2023-03-25 11:26:50 +01:00
kramo
501747ee36 Update translations v1.0 2023-03-25 11:26:28 +01:00
kramo
cb6fde38ef v1.0 2023-03-25 11:24:35 +01:00
kramo
3c71974d13 Merge pull request #18 from weblate/weblate-cartridges-cartridges 
Translations update from Hosted Weblate
 2023-03-25 11:12:57 +01:00
Hosted Weblate
e12d70cb95 Update translation files 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: Cartridges/Cartridges
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/
 2023-03-25 11:09:21 +01:00
Kimmo Kujansuu
002a753289 Translated using Weblate (Finnish) 
Currently translated at 100.0% (108 of 108 strings)

Translation: Cartridges/Cartridges
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fi/
 2023-03-25 11:09:21 +01:00
Kopimi
9ace39af6b Translated using Weblate (Finnish) 
Currently translated at 99.0% (107 of 108 strings)

Translation: Cartridges/Cartridges
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fi/
 2023-03-25 11:09:21 +01:00
Kimmo Kujansuu
af2b51779b Translated using Weblate (Finnish) 
Currently translated at 99.0% (107 of 108 strings)

Translation: Cartridges/Cartridges
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fi/
 2023-03-25 11:09:21 +01:00
rene-coty
5c748993c8 Translated using Weblate (French) 
Currently translated at 93.5% (101 of 108 strings)

Translation: Cartridges/Cartridges
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fr/
 2023-03-25 11:09:21 +01:00
Kimmo Kujansuu
4c740036cd Translated using Weblate (Finnish) 
Currently translated at 65.7% (71 of 108 strings)

Translation: Cartridges/Cartridges
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fi/
 2023-03-25 11:09:21 +01:00
LINUX-SAUNA
923aee6f1b Translated using Weblate (Finnish) 
Currently translated at 54.6% (59 of 108 strings)

Translation: Cartridges/Cartridges
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fi/
 2023-03-25 11:09:21 +01:00
Kimmo Kujansuu
f91c278dd0 Translated using Weblate (Finnish) 
Currently translated at 54.6% (59 of 108 strings)

Translation: Cartridges/Cartridges
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fi/
 2023-03-25 11:09:21 +01:00
LINUX-SAUNA
5345fa48bc Translated using Weblate (Finnish) 
Currently translated at 27.7% (30 of 108 strings)

Translation: Cartridges/Cartridges
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fi/
 2023-03-25 11:09:21 +01:00
Kimmo Kujansuu
a9ba84440d Translated using Weblate (Finnish) 
Currently translated at 27.7% (30 of 108 strings)

Translation: Cartridges/Cartridges
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fi/
 2023-03-25 11:09:21 +01:00
Kimmo Kujansuu
c528e559a3 Translated using Weblate (Finnish) 
Currently translated at 21.2% (23 of 108 strings)

Co-authored-by: Kimmo Kujansuu <mrkujansuu@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fi/
Translation: Cartridges/Cartridges
 2023-03-25 11:09:21 +01:00
LINUX-SAUNA
f52764d437 Translated using Weblate (Finnish) 
Currently translated at 21.2% (23 of 108 strings)

Translated using Weblate (Finnish)

Currently translated at 6.4% (7 of 108 strings)

Added translation using Weblate (Finnish)

Co-authored-by: LINUX-SAUNA <linuxsauna@protonmail.com>
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/fi/
Translation: Cartridges/Cartridges
 2023-03-25 11:09:21 +01:00
Óscar Fernández Díaz
95b3893b70 Translated using Weblate (Spanish) 
Currently translated at 100.0% (108 of 108 strings)

Translated using Weblate (Spanish)

Currently translated at 25.9% (28 of 108 strings)

Added translation using Weblate (Spanish)

Co-authored-by: Óscar Fernández Díaz <oscfdezdz@users.noreply.hosted.weblate.org>
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/es/
Translation: Cartridges/Cartridges
 2023-03-25 11:09:21 +01:00
kramo
716051d826 Fix games not launching on Windows 2023-03-25 11:09:12 +01:00
kramo
e3b24eafc0 Prepare for Flathub submission 2023-03-25 10:28:44 +01:00
kramo
f172385b6c Update screenshots 2023-03-25 09:29:47 +01:00
kramo
9dccb8f369 Add screenshots to metainfo.xml 2023-03-25 09:16:59 +01:00
kramo
2b7dfed1e3 Add screenshots 2023-03-25 09:01:00 +01:00
kramo
65357bdc41 UX improvements 2023-03-25 08:36:13 +01:00
kramo
69dfc9a717 Update translations 2023-03-25 00:51:34 +01:00
kramo
030c220d7e Cleanups 2023-03-25 00:50:17 +01:00
kramo
41c97e1af7 Move menu models to the game class 2023-03-25 00:14:37 +01:00
kramo
2f869a91ea Add Bananaman to credits 2023-03-24 23:36:47 +01:00
kramo
b65bab3528 Move toggle_hidden into the game class 2023-03-24 23:26:36 +01:00
kramo
ecceaabff1 Move run_command into the game class 2023-03-24 23:21:50 +01:00
kramo
6b103c996b Remove redundant get_cover function 2023-03-24 23:09:56 +01:00
kramo
fc2932f7dd Cleanups 2023-03-24 22:56:12 +01:00
kramo
bfa7cbfe08 Merge pull request #20 from Bananaman/launch_rework 
Improved game executable launcher, and added argument validation
 2023-03-24 22:42:09 +01:00
Bananaman
973ec01b38 Cleanup: Remove pointless calls to close() 
Since "with open()" automatically closes the files anyway.
 2023-03-24 22:37:01 +01:00
Bananaman
214687c9ce Cleanup: Remove backwards-compatible code 
Since we aren't interested in backwards compatibility this early in development, let's remove those code chunks to keep the code shorter.
 2023-03-24 22:35:55 +01:00
Bananaman
703c65395c Improved game executable launcher, and added argument validation 
Now uses proper shell escaping and parsing for all executable arguments, for more robust game launching. All existing game JSON files with the old string values will automatically be converted to the new format on app launch. The executable parsing uses the "shlex" library, which guarantees accurate parsing.

We now also use direct process launching (without any intermediary shell) by default, but the old "shell"-based launch method still exists in the code via an alternative flag in `run_command.py` (if we ever need to restore it for some reason).

Furthermore, if the user attempts to manually write an improperly escaped argument into the game's details (such as missing closing quotation marks), the GUI will now alert the user that their executable argument is invalid, along with telling them the exact reason why it's invalid.
 2023-03-24 22:03:39 +01:00
Bananaman
eda22c7ea7 Move game data JSON formatter to re-usable location 2023-03-24 22:03:39 +01:00
Bananaman
4e7e21ff6c Ignore flatpak-builder cache 2023-03-24 22:03:39 +01:00
kramo
bbf3703229 Cleanups 2023-03-24 21:53:55 +01:00
kramo
06550c0138 Fix heroic image string 2023-03-24 21:17:07 +01:00
kramo
4401378ce3 Use fstrings consistently 2023-03-24 21:07:08 +01:00
kramo
a665241d76 Disable some pylint warnings 2023-03-24 20:29:36 +01:00
Domenico
053d5791a4 Refactory of the code (#19) 
* Refactory of the code

* Autoformatting with black

---------

Co-authored-by: Domefemia <domefemia@hotmail.com>
 2023-03-24 20:26:55 +01:00
K.B.Dharun Krishna
df45ef411a Merge pull request #17 from weblate/weblate-cartridges-cartridges 
Translations update from Hosted Weblate
 2023-03-24 22:57:26 +05:30
kramo
8ddf609815 Use shlex for escaping quotes 2023-03-24 17:54:14 +01:00
Óscar Fernández Díaz
20e7cbf8b6 Added translation using Weblate (Spanish) 
Co-authored-by: Óscar Fernández Díaz <oscfdezdz@users.noreply.hosted.weblate.org>
 2023-03-24 17:49:07 +01:00
Ali Aljishi
ba6379f83a Translated using Weblate (Arabic) 
Currently translated at 100.0% (108 of 108 strings)

Translated using Weblate (Arabic)

Currently translated at 92.5% (100 of 108 strings)

Added translation using Weblate (Arabic)

Co-authored-by: Ali Aljishi <ahj696@hotmail.com>
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/ar/
Translation: Cartridges/Cartridges
 2023-03-24 17:49:06 +01:00
Alessandro Iepure
7f8c22df9e Translated using Weblate (Italian) 
Currently translated at 100.0% (108 of 108 strings)

Added translation using Weblate (Italian)

Co-authored-by: Alessandro Iepure <alessandro.iepure@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/it/
Translation: Cartridges/Cartridges
 2023-03-24 17:49:06 +01:00
Philip Goto
8c1ed2a254 Translated using Weblate (Dutch) 
Currently translated at 100.0% (108 of 108 strings)

Translated using Weblate (Dutch)

Currently translated at 100.0% (108 of 108 strings)

Added translation using Weblate (Dutch)

Co-authored-by: Philip Goto <philip.goto@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/cartridges/cartridges/nl/
Translation: Cartridges/Cartridges
 2023-03-24 17:49:05 +01:00